fix(router): fix middleware and plugin ordering#909
Open
Xenossolitarius wants to merge 2 commits intonuxt-modules:mainfrom
Open
fix(router): fix middleware and plugin ordering#909Xenossolitarius wants to merge 2 commits intonuxt-modules:mainfrom
Xenossolitarius wants to merge 2 commits intonuxt-modules:mainfrom
Conversation
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 49.59% 49.79% +0.20%
==========================================
Files 12 12
Lines 740 737 -3
Branches 52 52
==========================================
Hits 367 367
+ Misses 373 370 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@danielroe code is not covered by e2e tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#908
❓ Type of change
📚 Description
Added back ordering for the router middleware, tested most cases.
Unfortunately not sure the full story behind this ionic router integration so I am not completely confident but I started to create a new capacitor app and was with plugins being in race condition with the middleware. Which also breaks usage of pinia stores inside those too. I hope this PR helps.